Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

426 Upgrade required UI message is not shown #34960

Closed
btlechowski opened this issue Dec 18, 2023 · 2 comments · Fixed by brave/brave-core#21817
Closed

426 Upgrade required UI message is not shown #34960

btlechowski opened this issue Dec 18, 2023 · 2 comments · Fixed by brave/brave-core#21817
Assignees
@aseren
Labels
feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes regression release-notes/exclude
Milestone
1.63.x - Release

Comments

@btlechowski
Copy link

When refiling tokens fails with 426, we should show a modal.
The message was introduced #21388

Steps to Reproduce

  1. Override https://mywallet.ads.brave.com/v2/confirmation/token/* response code to 426
  2. Enable rewards and ads
  3. Connect to a custodian

Actual result:

Upgrade required UI modal is not shown

image image

Expected result:

Upgrade required UI modal is shown

image image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.62.107 Chromium: 120.0.6099.115 (Official Build) beta (64-bit)
Revision 67a3b21572338a0660bb25a5855da0f1e9372a39
OS Linux

cc @tmancey @aseren
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude labels Dec 19, 2023
@aseren aseren mentioned this issue Jan 30, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Jan 30, 2024
@brave-builds brave-builds mentioned this issue Jan 31, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2024

The above requires 1.63.143 or higher for 1.63.x verification 👍

@btlechowski
Copy link
Author

Verified with

Brave 1.63.157 Chromium: 122.0.6261.43 (Official Build) (64-bit)
Revision 5fbb7c60cc44e15a910a39a349e632f1b904c58e
OS Linux
image image

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes regression release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.63.x - Release
Development

Successfully merging a pull request may close this issue.

Fix Brave Ads 426 upgrade required UI message. brave/brave-core
5 participants
@tmancey @kjozwiak @btlechowski @brave-builds @aseren