Have a "hold to actually close" keyboard shortcut for pinned tabs

[bsclifton]

Description

Currently, pinned tabs can be closed with Ctrl+W / Cmd+W, and we've clarified this is the intended behavior.

A Chrome user recently suggested that we could have a "Hold X to close", similar to the Chrome/Chromium default behavior for Ctrl+Q/Cmd+Q for quit. It would look something like this:

Steps to Reproduce

1. Fresh profile
2. Visit a site
3. Right click tab, pick Pin Tab
4. Go into pinned tab
5. Hit Ctrl+W or Cmd+W

Actual result:

Pinned tab closes ☹️

Expected result:

User should have to hold shortcut to close

Reproduces how often:

100%

Brave version (brave://version info)

Brave	0.68.56 Chromium: 75.0.3770.90 (Official Build) nightly(64-bit)
Revision	a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS	Mac OS X

[rebron]

#4988 (comment)
Approach to solve inadvertently closing pinned tabs via ignoring CMD + W pref, might be a good way to go to instead of a warning.

[rebron]

cc: @rossmoody

[eljuno]

+1 from Community https://community.brave.com/t/possibly-quick-ux-improvement-for-pinned-tabs/99549?u=eljuno

[ibwoo]

+1 from me - a great idea that would be very helpful!

[yuujay]

+1. It gets little annoying when a pinned tab gets closed accidentally. Would be a very helpful UX improvement.

[iQuery-001]

+1 from me yes please

[yigitkonur]

+1

[radiosilence]

Much prefer the preference option. Often pinned tabs are closed when you spam/hold Cmd+W so having a message would probably be ineffective. What exactly is the point of pinning of they are so easy to close?

Someone suggested restoring the tab, but if you're like me and have a mix open on SoundCloud or whatever, it doesn't restore the playback.

[dvcrn]

I like the idea of having a setting to disable ever closing pinned tabs, similar to how safari is doing it. You can still right-click and then hit "close", but pinned tabs should be pinned until they are explicitly unpinned.

Hitting CMD-W on a pinned tab, if that tab is the last tab, should just close the browser window and leave the tab as is.

[thebatvic]

+1 from me.
It's already in WIP or it is still not take yet?

[gustavotrott]

I created an extension as a workaround to prevent pinned tabs from being closed accidentally:

https://github.com/gustavotrott/brave-lock-pinned-tabs

Feel free to use if it can help you guys to tackle this issue!

[ricardoprato]

+1

[gofort]

+1 for that feature
btw, extension posted above is a pretty great working workaround!