Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of PR #4252- Attention % value resets to zero in BR panel #8463

Closed
GeetaSarvadnya opened this issue Feb 28, 2020 · 2 comments · Fixed by brave/brave-core#5016
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 28, 2020

Description

Follow up of PR brave/brave-core#4252 Attention % value resets to zero in BR panel

Steps to Reproduce

  1. Clean profile 1.7.23 PR build - Launch using brave.exe --rewards=staging=true
  2. Enable rewards
  3. Open a site cnn.com and spend 10 sec on the site
  4. Open BR panel for CNN.com and ensure % attention value displayed in the panel
  5. Navigate to AC table and ensure attention % value displayed in AC table
  6. Open BR panel for Cnn.com again
  7. Attention % value for Cnn.com resets to zero

Actual result:

image

image
image

Expected result:

Attention % value should be displayed in BR panel

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.7.23 Chromium: 80.0.3987.122 (Official Build) nightly (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc

@LaurenWags
Copy link
Member

Reproduced with YT channel as well on macOS

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Apr 17, 2020

Verification passed on

Brave 1.8.77 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Ubuntu 18.04 LTS

Verified test plan from the description
Verified test plan from brave/brave-core#5016

Verified passed with

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description
  • Verified test plan from Fixes panel attention % not being shown brave-core#5016
  • Tried verified and non-verified creators, confirmed I could see the attention % in the panel
  • Confirmed attention % was updated on panel when visiting other sites and adding them to the AC table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment