Do not return unverified creators from activity table by default (upl…

…ift to 1.53.x) (#19046) Do not return unverified creators from activity table by default
brave · Jun 30, 2023 · 0931038 · 0931038
1 parent 7e559d5
commit 0931038
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/components/brave_rewards/common/mojom/ledger.mojom b/components/brave_rewards/common/mojom/ledger.mojom
@@ -174,7 +174,7 @@ struct ActivityInfoFilter {
   array<ActivityInfoFilterOrderPair> order_by;
   uint64 min_duration = 0;
   uint64 reconcile_stamp = 0;
-  bool non_verified = true;
+  bool non_verified = false;
   uint32 min_visits = 0;
 };
 

diff --git a/components/brave_rewards/core/database/database_activity_info_unittest.cc b/components/brave_rewards/core/database/database_activity_info_unittest.cc
@@ -99,7 +99,8 @@ TEST_F(DatabaseActivityInfoTest, GetRecordsListEmpty) {
             "ON ai.publisher_id = pi.publisher_id "
             "LEFT JOIN server_publisher_info AS spi "
             "ON spi.publisher_key = pi.publisher_id "
-            "WHERE 1 = 1 AND pi.excluded = ?";
+            "WHERE 1 = 1 AND pi.excluded = ? AND spi.status != 0 AND "
+            "spi.address != ''";
         ASSERT_EQ(transaction->commands[0]->command, query);
         ASSERT_EQ(transaction->commands[0]->record_bindings.size(), 14u);
         ASSERT_EQ(transaction->commands[0]->bindings.size(), 1u);
@@ -131,7 +132,8 @@ TEST_F(DatabaseActivityInfoTest, GetRecordsListOk) {
             "ON ai.publisher_id = pi.publisher_id "
             "LEFT JOIN server_publisher_info AS spi "
             "ON spi.publisher_key = pi.publisher_id "
-            "WHERE 1 = 1 AND ai.publisher_id = ? AND pi.excluded = ?";
+            "WHERE 1 = 1 AND ai.publisher_id = ? AND pi.excluded = ? "
+            "AND spi.status != 0 AND spi.address != ''";
         ASSERT_EQ(transaction->commands[0]->command, query);
         ASSERT_EQ(transaction->commands[0]->record_bindings.size(), 14u);
         ASSERT_EQ(transaction->commands[0]->bindings.size(), 2u);