Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gin::Wrappable leak #13955

Merged
merged 3 commits into from
Jun 25, 2022
Merged

Fix gin::Wrappable leak #13955

merged 3 commits into from
Jun 25, 2022

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Jun 24, 2022

Resolves brave/brave-browser#23681

  1. Revert Attach JSSolanaProvider to a RenderFrame #13934 which causing the crash
  2. Remove weak ptr usage for mojo, also fix att.com crash because wrong set_disconnect_handler binding uses weak ptr

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please test with v1.42.41 and higher
STR in brave/brave-browser#23645

@darkdh darkdh requested a review from bridiver June 24, 2022 22:35
@darkdh darkdh requested a review from a team as a code owner June 24, 2022 22:35
@darkdh darkdh self-assigned this Jun 24, 2022
@yrliou yrliou self-requested a review June 24, 2022 22:52
@darkdh darkdh changed the title Do not manually invalidate weak ptr in destructor Fix gin::Wrappable leak Jun 25, 2022
@darkdh darkdh force-pushed the solana-provider-crash branch from 406695d to d14be77 Compare June 25, 2022 00:46
@darkdh darkdh merged commit 23e64d9 into master Jun 25, 2022
@darkdh darkdh deleted the solana-provider-crash branch June 25, 2022 02:23
@darkdh darkdh added this to the 1.42.x - Nightly milestone Jun 25, 2022
darkdh added a commit that referenced this pull request Jun 29, 2022
darkdh added a commit that referenced this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants