-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android][Sync] Sync passwords from Android to Desktop #27271
Conversation
ba2b4a2
to
3bf8e91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
browser/password_manager/android/brave_password_manager_android_util_unittest.cc
Outdated
Show resolved
Hide resolved
3bf8e91
to
7d595cf
Compare
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "password, login" and so security team members have been added as reviewers to take a look. |
7d595cf
to
df9bacb
Compare
Released in v1.76.39 |
Verified on
Fresh installSTEPS:
ACTUAL RESULTS:
2025-01-27_10-41-52.mp4Upgraded profileSTEPS:
ACTUAL RESULTS:
2025-01-27_11-22-07.mp4 |
This PR forces passwords on Android to be saved into
Profile Store
instead ofAccount Store
, this allows passwords to be synced.Resolves brave/brave-browser#43303
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: