Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][Sync] Sync passwords from Android to Desktop #27271

Merged
merged 3 commits into from
Jan 25, 2025

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Jan 17, 2025

This PR forces passwords on Android to be saved into Profile Store instead of Account Store, this allows passwords to be synced.

Resolves brave/brave-browser#43303

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Create sync chain with Android and Desktop, enable passwords syncing
  2. Login to some site on Desktop, save password
  3. Ensure the password is synced to Android
  4. Login to some other site on Android, save password
  5. Expected the password from Android is synced to Desktop

@AlexeyBarabash AlexeyBarabash added the CI/skip Do not run CI builds (except noplatform) label Jan 17, 2025
@AlexeyBarabash AlexeyBarabash self-assigned this Jan 17, 2025
@AlexeyBarabash AlexeyBarabash changed the title [Android][Sync] Sync passwords from Android to Desktop; fixes brave/b… [Android][Sync] Sync passwords from Android to Desktop Jan 22, 2025
@AlexeyBarabash AlexeyBarabash removed the CI/skip Do not run CI builds (except noplatform) label Jan 22, 2025
@AlexeyBarabash AlexeyBarabash force-pushed the sync_pwd_from_android_to_desktop branch from ba2b4a2 to 3bf8e91 Compare January 22, 2025 12:09
@AlexeyBarabash AlexeyBarabash requested a review from darkdh January 22, 2025 15:16
@AlexeyBarabash AlexeyBarabash marked this pull request as ready for review January 22, 2025 15:17
@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner January 22, 2025 15:17
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@AlexeyBarabash AlexeyBarabash force-pushed the sync_pwd_from_android_to_desktop branch from 3bf8e91 to 7d595cf Compare January 24, 2025 22:01
Copy link
Contributor

The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "password, login" and so security team members have been added as reviewers to take a look.

No need to request a full security review at this stage, the security team will take a look shortly and either clear the label or request more information/changes.

Notifications have already been sent, but if this is blocking your merge feel free to reach out directly to the security team on Slack so that we can expedite this check.

@AlexeyBarabash AlexeyBarabash force-pushed the sync_pwd_from_android_to_desktop branch from 7d595cf to df9bacb Compare January 24, 2025 22:08
@AlexeyBarabash AlexeyBarabash merged commit 418c83a into master Jan 25, 2025
18 checks passed
@AlexeyBarabash AlexeyBarabash deleted the sync_pwd_from_android_to_desktop branch January 25, 2025 12:24
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 25, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.39

@hffvld
Copy link
Collaborator

hffvld commented Jan 27, 2025

Verified on Pixel 6 using version(s):

Device/OS: Pixel 6 / oriole-user 15 AP4A.241205.013 release-keys
Brave build: 1.76.40 
Chromium: 132.0.6834.111 (Official Build) canary (64-bit) 

Fresh install

STEPS:

  1. Follow the STR/TP from [Android][Sync] Sync passwords from Android to Desktop #27271 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that passwords that existed before creating the sync chain are synced between Desktop and Android after creating the sync chain.
  • Verified that newly saved passwords after sync chain creation are synced between Desktop and Android.

2025-01-27_10-41-52.mp4
Upgraded profile

STEPS:

  1. Install Brave 1.75.134 (where passwords are not synced and removed) on Android
  2. Login to some site > Save the password
  3. On Desktop go to some site > Save the password
  4. Create a sync chain and enable Password syncing on both devices
  5. Observe that Android passwords are not shown on Desktop - issue
  6. Upgrade Brave on Android to 1.76.40
  7. Go to Password Manager on both devices > Verify that all passwords are shown on both devices
  8. Remove Android device from the sync chain > Verify that passwords are not removed from any of these devices

ACTUAL RESULTS:

  • Verified that all old and newly saved passwords are synced between Desktop and Android after upgrading Brave from 1.75.134 to 1.76.40
  • Verified that passwords are not removed from Desktop or Android after removing the Android device from the sync chain.

2025-01-27_11-22-07.mp4

kjozwiak pushed a commit that referenced this pull request Jan 27, 2025
kjozwiak pushed a commit that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sync] Passwords are not synced from Android to Desktop
7 participants