fix(privacy): Improve cosmetic filtering performance on iOS #27272
+105
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setRulesOnStylesheetThrottled
to throttle instead of debounce.SelectorsPollerScript.js
we provide the page with a initial list of selectors to hide, then we send the remaining selectors on the page toCosmeticFiltersScriptHandler
to check againstAdblockEngine
. TheAdblockEngine
tells us which selectors to hide, and we send these back to the page to be hidden.SelectorsPollerScript.js
so we don't have to wait for the round trip from our javascript -> ScriptHandler -> AdblockEngine -> our javascript. This cache is reset when:Resolves brave/brave-browser#42530
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: