WebTorrent: Rename "Save File" to "Save .torrent File" #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
approved these changes
Jul 27, 2019
NejcZdovc
reviewed
Jul 28, 2019
| @@ -54,7 +54,7 @@ export default class TorrentViewerHeader extends React.PureComponent< | |||
| const mainButtonText = torrent ? 'Stop Torrent' : 'Start Torrent' | |||
| const copyButtonText = this.props.torrentId.startsWith('magnet:') | |||
| ? 'Copy Magnet Link' | |||
| : 'Save File' | |||
| : 'Save .torrent File' | |||
There was a problem hiding this comment.
probably we would like to add translations to torrent page
cc @rebron
There was a problem hiding this comment.
@NejcZdovc captured with brave/brave-browser#858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really trivial PR.
Fixes brave/brave-browser#5354
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.