Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Speed up shields settings migration. #5453

Closed
wants to merge 1 commit into from

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented May 4, 2020

Do not react to settings changes while migrating.

Resolves

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin self-assigned this May 4, 2020
Do not react to settings changes while migrating.
@mkarolin
Copy link
Collaborator Author

This fix is not likely to be relevant any more as most users would have migrated by now.

@mkarolin mkarolin closed this Jul 27, 2020
@bsclifton bsclifton deleted the maxk-fix-shields-settings-migration branch October 22, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant