NTP: Remove option to bookmark top sites (uplift to 1.9.x) #5512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brave-builds
requested review from
bbondy,
bsclifton,
kjozwiak,
rebron and
srirambv
kjozwiak
reviewed
May 12, 2020
There was a problem hiding this comment.
Uplift denied after deliberating with @brave/uplift-approvers. Due to both 1.8.x HF1 (Android) and 1.16.1 coming down the pipeline that includes the pub list/reward fixes, we're limiting the amount of work that's being uplifted into 1.9.x so we don't slip the schedule further.
Please let me know if you disagree or have any other questions regarding why the above was denied.
|
Re-opening since there is a hotfix coming up 😄 |
bsclifton
force-pushed
the
pr5490_ca-9481_1.9.x
branch
from
53ceabf to
46ce56a
Compare
|
Fix has been confirmed in Nightly by real user - I also had verified the functionality when merging PR |
|
Travis CI issue is known and not a blocker. Some dev dependencies (not used in product) are failing |
bsclifton
reviewed
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #5490
Fixes brave/brave-browser#9672
Approved, please ensure that before merging:
After you merge: