Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Puppeteer Tests for Google, Proton, and Skiff #40

Merged
merged 8 commits into from
Aug 1, 2023

Conversation

jonathansampson
Copy link
Collaborator

This is a fairly large PR, so I won't be heart-broken if there are several items which require further attention 🙂 This PR delivers initial support for Puppeteer-Driven tests on Google Calendar, Proton Calendar, and Skiff Calendar.

Addresses #33

@jonathansampson jonathansampson requested a review from tackley July 6, 2023 20:31
@socket-security
Copy link

socket-security bot commented Jul 6, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
jest-puppeteer 9.0.0 eval, shell +89 20.7 MB neoziro
dotenv 16.3.1 environment +0 71.6 kB motdotla
puppeteer-core 20.9.0 network, filesystem, shell, environment +55 21 MB google-wombot

package-lock.json Outdated Show resolved Hide resolved
@jonathansampson jonathansampson force-pushed the sampson-puppeteer-tests branch from 437ad63 to dd00e3e Compare July 14, 2023 14:30
Our tests now require an instance of Brave, as well as authenticated sessions. As such, they will be ran locally prior to any commits until we decide otherwise.
@jonathansampson jonathansampson force-pushed the sampson-puppeteer-tests branch 3 times, most recently from 80d7b46 to f9d7817 Compare July 31, 2023 19:50
@jonathansampson jonathansampson force-pushed the sampson-puppeteer-tests branch from f9d7817 to 70bc851 Compare July 31, 2023 22:13
Copy link
Collaborator

@tackley tackley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a few minor nits to address, this looks great!

.vscode/settings.json Outdated Show resolved Hide resolved
.github/workflows/check-and-build.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jonathansampson jonathansampson requested a review from tackley August 1, 2023 12:25
@jonathansampson jonathansampson merged commit 7b641ec into master Aug 1, 2023
@jonathansampson jonathansampson deleted the sampson-puppeteer-tests branch August 1, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants