This repository has been archived by the owner on Jul 31, 2020. It is now read-only.
Add requestUtil.bufferedPut to limit concurrency of put #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like travis is borked tho prolly unrelated to this change |
diracdeltas
reviewed
Jun 29, 2017
client/requestUtil.js
Outdated
| const s3Prefix = this.currentRecordPrefix(category) | ||
| const s3Keys = s3Helper.encodeDataToS3KeyArray(s3Prefix, record) | ||
| const encryptedRecord = this.encrypt(record) | ||
| const thisCategory = category || getRecordCategory(record) |
There was a problem hiding this comment.
should this throw an error if thisCategory is not one of the expected values?
diracdeltas
suggested changes
Jun 29, 2017
Deprecate SEND_SYNC_RECORDS category to be optional and derived from each record. Required for #112
ayumi
force-pushed
the
fix/limit-put-concurrency
branch
from
04c2b05 to
eae9b0d
Compare
diracdeltas
approved these changes
Jun 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
putConcurrency is configurable with ipc GOT_INIT_DATA.
Also deprecate SEND_SYNC_RECORDS category to be optional, defaulting to the record objectData.
Required for #112