Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong position computation between first and other lines #18

Closed
bago opened this issue Jun 11, 2015 · 1 comment
Closed

Wrong position computation between first and other lines #18

bago opened this issue Jun 11, 2015 · 1 comment
Assignees
@bago

Comments

@bago
Copy link
Collaborator

bago commented Jun 11, 2015

On line 1 the first column is column 1, on the following lines the first column is column 0.
I guess the correct positioning is the one when the first char is col:1, line:1 so the right solution is to have following lines to start with 1 too.
bago added a commit to bago/mensch that referenced this issue Jun 11, 2015
@bago
Fix tests under windows and position "col" for lines but the first
b40a550 
Fixes brettstimmerman#17 and brettstimmerman#18
@bago
Copy link
Collaborator Author

bago commented Jun 12, 2015

I'm not going to open a PR for this, because I have too many local changes: if you are interested please accept the previous PR and then I'll create a new one.

@bago bago self-assigned this Aug 18, 2015
@bago bago closed this as completed Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bago bago

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bago