Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding specification of a user supplied exception override class #1551

Closed

Conversation

cardid-zz
Copy link

For those cases when HikariCP cannot establish connection for some reasons, like changed password, may need to shutdown entire HikariCP Datasource.
I expanded previously added SQLExceptionOverride class by adding method onException which passing instance of HikariDatasource and exception to application.

@cardid-zz cardid-zz changed the title Expand specification of a user supplied exception override class Expanding specification of a user supplied exception override class Mar 5, 2020
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.66%. Comparing base (ed2da5f) to head (91d998e).
Report is 128 commits behind head on dev.

Files with missing lines Patch % Lines
...n/java/com/zaxxer/hikari/SQLExceptionOverride.java 0.00% 1 Missing ⚠️
...c/main/java/com/zaxxer/hikari/pool/HikariPool.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1551      +/-   ##
============================================
- Coverage     70.75%   70.66%   -0.09%     
- Complexity      575      578       +3     
============================================
  Files            26       26              
  Lines          2171     2182      +11     
  Branches        311      312       +1     
============================================
+ Hits           1536     1542       +6     
- Misses          484      486       +2     
- Partials        151      154       +3     
Files with missing lines Coverage Δ
src/main/java/com/zaxxer/hikari/HikariConfig.java 77.71% <100.00%> (+0.18%) ⬆️
.../main/java/com/zaxxer/hikari/HikariDataSource.java 78.57% <ø> (ø)
src/main/java/com/zaxxer/hikari/pool/PoolBase.java 72.56% <100.00%> (+0.40%) ⬆️
...n/java/com/zaxxer/hikari/SQLExceptionOverride.java 60.00% <0.00%> (-15.00%) ⬇️
...c/main/java/com/zaxxer/hikari/pool/HikariPool.java 80.99% <66.66%> (-0.14%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2da5f...91d998e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants