Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak 'make test' #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

debarshiray
Copy link
Contributor

The vendor directory was updated with go mod vendor.

Otherwise make test fails with:

  $ make test
  go test -v -cover ./...
  go: inconsistent vendoring in /path/to/briandowns/spinner:
	golang.org/x/[email protected]: is
	    explicitly required in go.mod, but not marked as explicit in
	    vendor/modules.txt
	golang.org/x/[email protected]: is marked
	    as explicit in vendor/modules.txt, but not explicitly
	    required in go.mod

	To ignore the vendor directory, use -mod=readonly or -mod=mod.
	To sync the vendor directory, run:
		go mod vendor
  make: *** [Makefile:12: test] Error 1

Fallout from 12e6c29

@briandowns
Copy link
Owner

Thank you for the contribution. I've been meaning to simply get rid of the vendor directory in this branch but haven't since I'm working on the v2 replacement. I'd rather we just remove the vendor directory entirely.

The 'vendor' directory was removed because it keeps getting outdated
compared to go.mod.

Otherwise 'make test' fails with:
  $ make test
  go test -v -cover ./...
  go: inconsistent vendoring in /path/to/briandowns/spinner:
	golang.org/x/[email protected]: is
	    explicitly required in go.mod, but not marked as explicit in
	    vendor/modules.txt
	golang.org/x/[email protected]: is marked
	    as explicit in vendor/modules.txt, but not explicitly
	    required in go.mod

	To ignore the vendor directory, use -mod=readonly or -mod=mod.
	To sync the vendor directory, run:
		go mod vendor
  make: *** [Makefile:12: test] Error 1

Fallout from 12e6c29
@debarshiray debarshiray force-pushed the wip/rishi/unbreak-make-test-go-mod-vendor branch from 6e9b126 to 508a84e Compare November 5, 2024 16:24
@debarshiray
Copy link
Contributor Author

Thanks for the review!

Thank you for the contribution. I've been meaning to simply get rid of the vendor directory in this branch but haven't since I'm working on the v2 replacement. I'd rather we just remove the vendor directory entirely.

I have now removed the vendor directory completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants