Given the min and max parameter the ZipfianGenerator should not return *0*… #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if (uz < 1) nor 1 if (uz<1.0+Math.pow(0.5,theta)). Instead it should return the min value (base) or min + 1.
| @@ -0,0 +1,23 @@ | |||
| package com.yahoo.ycsb.generator; | |||
There was a problem hiding this comment.
this file needs a license header.
| @@ -0,0 +1,39 @@ | |||
| /** | |||
| * Copyright (c) 2010 Yahoo! Inc. All rights reserved. | |||
There was a problem hiding this comment.
nit: the year here should be the year of authorship. I'm fine fixing this while doing a sanity check on license headers as a part of #266. Let me know if you want to fix it now instead. If I don't hear anything I'll merge this tonight.
There was a problem hiding this comment.
Sorry for that. Please feel free to fix it as part of #266.
busbey
added a commit
that referenced
this pull request
Jun 4, 2015
[core] Given the min and max parameter the ZipfianGenerator should not return *0*…
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
[core] Given the min and max parameter the ZipfianGenerator should not return *0*…
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
[core] Given the min and max parameter the ZipfianGenerator should not return *0*…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
if (uz < 1)nor 1if (uz<1.0+Math.pow(0.5,theta)). The pseudo code in [1] (referenced by ycsb) assumes that only values between 1 and N are drawn from the distribution, but given a min parameter the min value should be returnedif (uz < 1), resp. min + 1if (uz<1.0+Math.pow(0.5,theta)).[1] J. Gray et al. Quickly generating billion-record synthetic databases. In SIGMOD, 1994.