Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cassandra2] added better property handling #536

Merged
merged 1 commit into from
Dec 17, 2015

Conversation

kruthar
Copy link
Collaborator

@kruthar kruthar commented Dec 17, 2015

This PR actually fixes two issues, both related to property handling in the cassandra2-cql client.

  1. In the spirit of keeping the clients as baseline as possible, I removed the magic number updates to read and connect timeouts to the cluster. Instead I exposed these properties to the user.
  2. No longer setting the max connections to threadcount. As I discussed in [Cassandra] cassandra2-cql fails with threadcount of 1 on Cassandra 2.0 #534, YCSB threads are not directly related with Cassandra Connections. I also exposed these settings to the user for fine tuning.

This PR would fix #534 and allows the cassandra2-cql client to be used on all Cassandra 2.X versions making the deprecation of the cassandra-binding in #532 a little easier.

@cmccoy
Copy link
Collaborator

cmccoy commented Dec 17, 2015

+1. Thanks, @kruthar!

kruthar added a commit that referenced this pull request Dec 17, 2015
[cassandra2] added better property handling
@kruthar kruthar merged commit 76a8141 into brianfrankcooper:master Dec 17, 2015
@kruthar kruthar deleted the cassandra2-properties branch December 17, 2015 16:31
@bigbes bigbes mentioned this pull request Dec 20, 2015
jaricftw pushed a commit to jaricftw/YCSB that referenced this pull request Jul 19, 2016
…rties

[cassandra2] added better property handling
jaricftw pushed a commit to jaricftw/YCSB that referenced this pull request Jul 19, 2016
…rties

[cassandra2] added better property handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cassandra] cassandra2-cql fails with threadcount of 1 on Cassandra 2.0
2 participants