[Cassandra] removed tracing from insert #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you isolate this PR to just the Cassandra issue? |
|
Definitely accidentally left. Other than @busbey's comment, 👍. We should pull this into v0.6.0. |
mike-petersen
force-pushed
the
master
branch
from
7aea94d to
d43c993
Compare
|
I have isolated the cassandra issue |
|
@cmccoy let's merge it, then and release 0.6.0-rc2? |
|
Sounds good.
|
busbey
added a commit
that referenced
this pull request
Dec 31, 2015
[Cassandra] removed tracing from insert
|
Thanks for the improvement! |
Closed
Closed
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
[Cassandra] removed tracing from insert
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
[Cassandra] removed tracing from insert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i removed the tracing from the insert statement cause it had a severe impact in performance.
Was there a reason for that or was i just left accidentally in the code?
Regards
Mike