[orientdb] added test cases #569
Conversation
|
So, this was a weird failure, seem that whatever location clojars was could not be reached. I reran the build and things are green. |
| @@ -0,0 +1,228 @@ | |||
| package com.yahoo.ycsb.db; | |||
There was a problem hiding this comment.
File needs a license header.
There was a problem hiding this comment.
Indeed it does. Added.
kruthar
force-pushed
the
orientdb-testing
branch
from
009e62c to
11a8596
Compare
kruthar
force-pushed
the
orientdb-testing
branch
from
11a8596 to
1fda14a
Compare
|
@busbey - thanks for the tip, exceptions now propogating |
| This is a copy of buildDeterministicValue() from core:com.yahoo.ycsb.workloads.CoreWorkload.java. | ||
| That method is neither public nor static so we need a copy. | ||
| */ | ||
| private String buildDeterministicValue(String key, String fieldkey) { |
There was a problem hiding this comment.
Any thoughts on this copying vs using something like powermock to access the method vs making the original visible for testing?
There was a problem hiding this comment.
Thinking about this more, I agree that copying makes the most sense right now. It probably points to a need to come up with a common strategy for these kinds of tests, but that's not an issue for this PR.
There was a problem hiding this comment.
Agreed on your last point, needs deeper thought on consolidated testing strategy in the future.
|
+1 |
|
Thanks @busbey |
[orientdb] added test cases
[orientdb] added test cases
Added basic operational test cases for the orientdb binding. Should give a little assurance to future cleanup work.