-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[orientdb] Added remote connection capabilties #581
Conversation
* Default: ```false``` | ||
* ```orientdb.remote.storagetype``` - Storage type of the database on remote server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is surprising.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, a remote connection can be used to connect to a long living plocal or memory database on the server. Memory databases stored on the server don't die like local memory databases do. This being the case you could have two databases with the same name but different types, and so when doing any administration of remote databases you have to know the storage type.
7094d91
to
93daa21
Compare
@@ -46,6 +49,7 @@ | |||
private static final String CLASS = "usertable"; | |||
protected ODatabaseDocumentTx db; | |||
private ODictionary<ORecord> dictionary; | |||
private boolean isRemote = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this default to true since other bindings default to remote?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether or not the connection is a remote connection is purely dependent on the url provided by the user, so really there is not default. isRemote
is defaulted to false because it is only set to true if the user provides a remote connection url, in any other case (user provides a local url) it should be false.
93daa21
to
1fc0041
Compare
Made a few edits:
|
1fc0041
to
5417219
Compare
Looks good to me. |
+1 |
[orientdb] Added remote connection capabilties
[orientdb] Added remote connection capabilties
[orientdb] Added remote connection capabilties
Had to implement a separate init path for remote connections using OServerAdmin. The old, local init path is essentially the same as before.
OrientDB does not support the iterator methods that scan is built off of for remote connections, so had to check for that and record NOT_IMPLEMENTED. Made a note of that in the README as well.