[solr] Added tests for Solr binding #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - Default value is `false` and therefore expects solr to be running in stand-alone mode. | ||
|
|
||
| - `solr.base.url` | ||
| - The base URL in which to interface with a running Solr instance in Stand=alone mode |
|
Dammit, did I comment on the wrong PR? Assume all my comments go to the other one then, if so. Sorry. :( |
risdenk
force-pushed
the
solr-test
branch
2 times, most recently
from
19c1a1c to
9f36bcc
Compare
|
@busbey addressed comments about putting reference to Solr config files and configuring log4j to go to stderr. |
busbey
changed the title
| limitations under the License. | ||
| --> | ||
| <!-- | ||
| Copied from Apache Solr solr/solrj/src/test-files/solrj/solr/collection1/conf/schema.xml |
There was a problem hiding this comment.
a release tag (or lacking one a commit hash) would be preferable, so that folks who want to inspect the original can.
There was a problem hiding this comment.
Fixed. Added to schema.xml and solrconfig.xml
busbey
added a commit
that referenced
this pull request
Jan 13, 2016
[solr] Added tests for Solr binding
|
thanks! |
Closed
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
[solr] Added tests for Solr binding
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
[solr] Added tests for Solr binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on PR #574. Relates to @busbey comment about testing the Solr binding #574 (comment). Will most likely need to be rebased after #574 is merged.