Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientdb checkstyle #585

Merged
merged 2 commits into from
Jan 18, 2016
Merged

Conversation

kruthar
Copy link
Collaborator

@kruthar kruthar commented Jan 18, 2016

  • Rabased pull/489/head to master
  • Backed out unnecessary line breaks for 120 char limit
  • Enforced checkstyle on new code
    • Was required to make db variable private, updated in tests
    • Removed TODO

Closes #489

@@ -0,0 +1,22 @@
/*
* Copyright (c) 2014, Yahoo!, Inc. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this year correct?

* Rabased pull/489/head (@allanbank) to master
* Backed out unnecessary line breaks for 120 char limit
* Enforced checkstyle on new code
  * Was required to make db variable private, updated in tests
  * Removed TODO

Closes brianfrankcooper#489
@kruthar kruthar force-pushed the orientdb-checkstyle branch from 03d4d6e to 759f6e1 Compare January 18, 2016 15:48
@kruthar
Copy link
Collaborator Author

kruthar commented Jan 18, 2016

All comments addressed.

@busbey
Copy link
Collaborator

busbey commented Jan 18, 2016

+1

kruthar added a commit that referenced this pull request Jan 18, 2016
@kruthar kruthar merged commit 942c46a into brianfrankcooper:master Jan 18, 2016
@kruthar kruthar deleted the orientdb-checkstyle branch January 18, 2016 15:56
@risdenk risdenk mentioned this pull request Feb 15, 2016
jaricftw pushed a commit to jaricftw/YCSB that referenced this pull request Jul 19, 2016
jaricftw pushed a commit to jaricftw/YCSB that referenced this pull request Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants