Orientdb cleanup #586
Merged
Orientdb cleanup #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dictionary = db.getMetadata().getIndexManager().getDictionary(); | ||
| if (!db.getMetadata().getSchema().existsClass(CLASS)) { | ||
| db.getMetadata().getSchema().createClass(CLASS); | ||
| } | ||
|
|
||
| db.declareIntent(new OIntentMassiveInsert()); | ||
| if (intent.equals(ORIENTDB_MASSIVEINSERT)) { |
There was a problem hiding this comment.
Should these be set automatically per type of action? Like insert should be massiveinsert, read should be massiveread, etc? Or is it assumed that these settings will be set when someone runs a workload?
There was a problem hiding this comment.
No, I don't think they should be set automatically, that is actually why I moved this to a user property. It is an optimization, not a necessary action. Prior to this change MassiveInsert was being set no matter what which didn't much make since for workloads that weren't inserting.
|
👍 looks good to me. |
Closed
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
Orientdb cleanup
jaricftw
pushed a commit
to jaricftw/YCSB
that referenced
this pull request
Jul 19, 2016
Orientdb cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things fixed here: