Dynamodb API update #592
Dynamodb API update #592
Conversation
|
@stfeng , PTAL |
|
Code LGTM. Thanks for doing the performance regression validation to make sure the new API does not perform worse than the old one. (Your results show they are within ~0.3% of each other) |
|
Please take a look at the Travis CI build error though... |
|
Thanks for taking care of the Travis build issue. All green now. One final minor thing: Can you edit both of your commits to start with [DynamoDB]? We always prefix commits with [DB-binding-name], or [core](if the code is in YCSB core). |
| k = new Key() | ||
| .withHashKeyElement(new AttributeValue().withS(hashKeyValue)) | ||
| .withRangeKeyElement(new AttributeValue().withS(key)); | ||
| k = new HashMap<String, AttributeValue>(); |
There was a problem hiding this comment.
Does k need to be a new hashmap here? Looks like it is initialized on line 343 already.
|
@yuyantingzero does dynamodb use v1 anymore? Will these changes make testing some versions of DynamoDB not possible? |
|
as a point of clarification for @risdenk's comment, making it so we can't test earlier versions of DynamoDB isn't a blocker. It just means we have to weigh the benefit of maintaining that ability against the cost of breaking this into a new binding module (see the HBase modules or Cassandra modules as an example). |
|
@risdenk, the DynamoDB v1 client API has been deprecated since Apr 2013 when AWS released the 1.4.2 Java SDK. Upgrading to v2 client API is a long overdue task for this DB binding. ;) |
|
Great thanks @stfeng |
|
Looks good to me 👍 |
|
LGTM, merging. |
ghost
merged commit 
Dynamodb API update
Dynamodb API update
Run workloada from an external vm to dynamodb, the performance difference between dynamodb v1 and v2 api. Results:
percentile, v1 read, v1 write, v2 read, v2 write
0.1, 34775.9, 36097, 35244, 36357
0.5, 35869.5, 36843, 36658, 37602
0.95, 39209.1, 42328.75, 41423, 43277.9
0.99, 54295.1, 68858.76, 56915, 63764.16