Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): fix typo dependancies -> dependencies #6303

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Farfaday
Copy link

@Farfaday Farfaday commented May 14, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

fix typo "dependancies" -> "dependencies"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Corrects the spelling of "dependencies" across multiple files in the project. Updates the validate_runner_deps method in the runner dependency handler, modifies logging messages in the Helm and Kustomize runners, and adjusts comments for clarity. These changes ensure consistent terminology throughout the codebase.

TopicDetails
Typo fix Corrects the spelling of 'dependencies' throughout the codebase
Modified files (3)
  • checkov/kustomize/runner.py
  • checkov/helm/runner.py
  • checkov/common/util/runner_dependency_handler.py
Latest Contributors(2)
UserCommitDate
bo156feat-helm-Made-helm-ku...November 17, 2024
rotemavnifix-helm-Remove-helm-t...October 14, 2024
This pull request is reviewed by Baz. Join @Farfaday and the rest of your team on (Baz).

@ChananM
Copy link
Contributor

ChananM commented Dec 8, 2024

Hi @Farfaday, thank you for your contribution!
Please revise the PR title to adhere to the repo naming conventions. I suggest fix(general)

@Farfaday Farfaday changed the title fix(typo): fix typo dependancies -> dependencies fix(general): fix typo dependancies -> dependencies Dec 8, 2024
@Farfaday
Copy link
Author

Farfaday commented Dec 8, 2024

@ChananM done :)

@AdamDev
Copy link
Contributor

AdamDev commented Jan 5, 2025

Hi @Farfaday, thank you for your contribution!
Could you please pull from main and push again, so we can proceed with this PR?

Copy link
Contributor

@MaryArmaly MaryArmaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Farfaday,
Could you please merge the latest changes from the main branch into your branch again? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants