Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): add option to add external_modules_content_cache to terraform build_graph #6942

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

lirshindalman
Copy link
Contributor

@lirshindalman lirshindalman commented Jan 9, 2025

User description

…nager

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Adds support for external modules content cache in Terraform graph building. Modifies multiple graph manager files to include an additional **kwargs parameter, allowing for the new external_modules_content_cache option in the Terraform graph manager. Updates the Terraform runner to accommodate these changes.

TopicDetails
Terraform Cache Implements external modules content cache for Terraform graph building to improve performance
Modified files (2)
  • checkov/terraform/graph_manager.py
  • checkov/terraform/runner.py
Latest Contributors(2)
UserCommitDate
SteveVakninfix-terraform-fix-fail...July 17, 2024
lirshindalmanplatform-general-remov...January 28, 2024
Graph Manager Update Adds **kwargs parameter to multiple graph manager files for consistency and future extensibility
Modified files (8)
  • checkov/common/graph/graph_manager.py
  • checkov/arm/graph_manager.py
  • checkov/bicep/graph_manager.py
  • checkov/cloudformation/graph_manager.py
  • checkov/common/runners/graph_manager.py
  • checkov/dockerfile/graph_manager.py
  • checkov/serverless/graph_manager.py
  • checkov/kubernetes/graph_manager.py
Latest Contributors(2)
UserCommitDate
omriyoffe-panwfeat-serverless-Server...December 04, 2024
lirshindalmanfeat-arm-Add-arm-defin...October 30, 2024
This pull request is reviewed by Baz. Join @lirshindalman and the rest of your team on (Baz).

@lirshindalman lirshindalman merged commit f78b038 into main Jan 9, 2025
38 checks passed
@lirshindalman lirshindalman deleted the add_kwargs_to_build_graph_from_source_directory branch January 9, 2025 12:43
Saarett pushed a commit that referenced this pull request Jan 9, 2025
…terraform build_graph (#6942)

* add option to add external_modules_content_cache to terraform GraphManager

* add option to add external_modules_content_cache to terraform GraphManager

* add option to add external_modules_content_cache to terraform GraphManager

* add option to add external_modules_content_cache to terraform GraphManager

* add option to add external_modules_content_cache to terraform GraphManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants