RELEASE 0.3.0 #79
Merged
RELEASE 0.3.0 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrista
suggested changes
Dec 2, 2019
paquettealice
force-pushed
the
feat/0.3.0
branch
from
d8f6f9e to
ccd77ec
Compare
|
In the middle of rebasing but have to go eat, so things will look weird for a bit :p |
paquettealice
force-pushed
the
feat/0.3.0
branch
3 times, most recently
from
d075ac4 to
aad832c
Compare
|
Rebasing should be done, and I made two changes:
Please let me know if you want additional changes! |
paquettealice
force-pushed
the
feat/0.3.0
branch
from
aad832c to
5f3b59c
Compare
paquettealice
commented
Dec 19, 2019
added 2 commits
January 6, 2020 08:48
+ Add ICorrelatedAction interface * Update all EntityActions to include a correlationId (defaults to uuidv4()) * Update all operators to propagate correlationId from initiators to results * Update peer dependencies to use proper syntax Part of release 0.3.0 Resolves briebug#75
+ Add the ability to create and edit orders * Update some of the look and feel * Refactor some of the code into effects (still needs work) Part of release 0.3.0
paquettealice
force-pushed
the
feat/0.3.0
branch
from
5f3b59c to
12548cb
Compare
|
@jrista Pushed the changes to the versions, check them out when you can. |
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <[email protected]>
jrista
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the new
correlationIdproperty for allEntityActions. The changes to the library itself are spread wide but quite shallow, so it shouldn't be too bad to review. The demo app changes are quite heavy however, and I unfortunately don't have time for a full write-up. The broad strokes for both are as follow:Library
uuidv4ICorrelatedActionwith just one property:correlatedIdIEntityActionnow extends bothActionandICorrelatedActionEntityActionclass constructor now accepts an optional 3rd argument:public correlationId: string = uuid()EntityActionnow accept an optional 3rd argument:correlationId?: stringwhich is passed tosuper()correlationIdto subsequentSuccessandFailureactions, linking those sets of actions togethercorrelationIdargument to the BaseFacade's dispatch methods (and pass it down the chain like it's done above)? E.g.load,loadMany,create,update, etc.Demo
If you have any questions, don't hesitate to ask!
P.S. I didn't add any unit tests for the library changes (I completely forgot and I'm crazy strained for time lately), so if you'd rather wait until I can get those up before merging, that's completely fine.