-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update brigade.sh design #55
Conversation
✔️ Deploy Preview for v2-brigade ready! 🔨 Explore the source changes: d57f937 🔍 Inspect the deploy log: https://app.netlify.com/sites/v2-brigade/deploys/61df0fdabb2f670008fc22ba 😎 Browse the preview: https://deploy-preview-55--v2-brigade.netlify.app |
@flynnduism this is amazing. And the background animation is mesmerizing. It's literally fun just to scroll. But it's not fun just for fun's sake -- I feel like that animation really represents what Brigade does. Awesome! |
A couple notes about content:
cc @vdice |
Thanks Kent, I'll update with these edits. I have cleanup and CSS polishing to do during the week, I will update the content according to your points here too.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so great, @flynnduism ! 👏
Stoked as well on the vastly simplified build approach and slimmed-down dependency tree.
index.html
Outdated
</li> | ||
<li class="slide-trigger"> | ||
<label for="img-2" id="img-dot-2"> | ||
<img src="assets/images/ex-icon-07.png" /> Update a CosmosDB database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<img src="assets/images/ex-icon-07.png" /> Update a CosmosDB database | |
<img src="assets/images/ex-icon-07.png" /> Update a MongoDB database |
(per #55 (comment))
index.html
Outdated
</li> | ||
<li class="slide-trigger"> | ||
<label for="img-3" id="img-dot-3"> | ||
<img src="assets/images/ex-icon-05.png" /> Send a Slack message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<img src="assets/images/ex-icon-05.png" /> Send a Slack message | |
<img src="assets/images/ex-icon-05.png" /> Handle a Slack message event |
(per #55 (comment))
index.html
Outdated
|
||
<p>Brigade can be used to chain containers together to build processing pipelines.</p> | ||
<ul class="fancy"> | ||
<li>Watch for incoming requests from services like GitHub, Docker, and Trello</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<li>Watch for incoming requests from services like GitHub, Docker, and Trello</li> | |
<li>Watch for incoming requests from services like GitHub, Docker, and BitBucket</li> |
(per #55 (comment))
Here's a new YouTube video we can use: https://www.youtube.com/watch?v=EqJ9_k56Q3U |
Just wanted to check if this is close to mergeable. v2 has gone GA this afternoon. |
@krancour congratulations! I will apply these edits and feedback items today to get this finalized asap! |
Thanks @flynnduism! |
@krancour @vdice I've updated this PR with the suggested content edits and some minor design cleanups. CICD Note: the netlify config for the site will not pass this PR, as the command to build the site needs to change for the new (non-jekyll) tooling. You can preview the build properly here https://v2.brigade.sh/ Build command will change from:
to:
|
@flynnduism this looks great! I do notice some elements overlapping in ways that I don't think were intended. Example: And the overlapping is a bit different in different browsers. Ugh. I had hoped the days of browsers rendering sites differently were mostly behind us. |
@flynnduism just wanted to follow up. Are we close on this? |
Super-nit that can be totally ignored until a later time — it would be great if we had some basic syntax highlighting for the examples on the main page. |
@krancour I've pushed layout changes for the various mobile and desktop states, to fix the issue where some of the content panels overlapped each other. |
A lot of the Netlify checks are failing. I suspect the recent move to CNCF's Netlify account may have something to do with it. I'll volunteer to investigate that. |
@krancour the test fails here are to be expected, as the v1 site checks here are expecting This PR can be tested at a different location (v2.brigade.sh), and if it looks good to ship the Netlify build command can be swapped out for the prod instance of the website. |
@flynnduism it looks like this needs to be rebased on the v2 branch. There aren't actually any conflicts. I'd do it myself, but I can't push to your branch. After that, if you also think this is ready, LGTM.
Edit: I did deploy this already to https://v2.brigade.sh for anyone who wants to preview it. |
@flynnduism, alternatively, I can do the rebase if you check the "Allow edits and access to secrets by maintainers" box on the PR. |
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.11.4 to 1.12.5. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.11.4...v1.12.5) --- updated-dependencies: - dependency-name: nokogiri dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
* for a one page site jekyll is overkill * changes this from a static site to a simple index.html * use parcel.js to handle the scss to css compilation * this removes the need for ruby, bundler, gulp and most packages Signed-off-by: flynnduism <[email protected]>
Signed-off-by: flynnduism <[email protected]>
Signed-off-by: flynnduism <[email protected]>
Signed-off-by: flynnduism <[email protected]>
Signed-off-by: flynnduism <[email protected]>
Signed-off-by: flynnduism <[email protected]>
Signed-off-by: flynnduism <[email protected]>
Signed-off-by: flynnduism <[email protected]>
Rebase is in @krancour, sorry for the delay. Ready for 👀 |
This is brings a brand refresh to the Brigade site. Preview here: https://v2.brigade.sh/
Main changes:
Content changes:
One of the biggest challenges for Brigade has always been showing off some of the cool stuff that Brigade can do - I want to try and plug in a few things here to expand on the old copy which has largely sat unchanged since the "we're launching a new thing called Brigade" phase back in 2017.
I added a short paragraph here trying to talk about what seems like one of the project's key standout features, but we don't really talk about it very much. I think it would be nice to talk about the way Brigade 2 is built to handle large streams of events and works to process jobs very very quickly. But I need some help and input on hopw best to communicate this.
This is hopefully a decent start on re-framing the project's value prop and showing the new cool stuff in v2, but I would love some input on how I can better articulate this stuff!