Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brigade.sh design #55

Merged
merged 10 commits into from
Jan 12, 2022
Merged

Update brigade.sh design #55

merged 10 commits into from
Jan 12, 2022

Conversation

flynnduism
Copy link
Collaborator

This is brings a brand refresh to the Brigade site. Preview here: https://v2.brigade.sh/


Screen Shot 2021-11-22 at 1 28 15 PM

Main changes:

  • updates logos, colors, fonts, etc
  • instead of static background images dotted along the site, this adds an expanding pipes animation in the background that unfolds as you scroll the page
  • removes the need for ruby/jekyll/gems/a lot of npm packages that were way overkill for the site to run. now a lighter stack using parceljs to handle the landing page assets.

Content changes:

One of the biggest challenges for Brigade has always been showing off some of the cool stuff that Brigade can do - I want to try and plug in a few things here to expand on the old copy which has largely sat unchanged since the "we're launching a new thing called Brigade" phase back in 2017.

  • Added a video overview of Brigade. There's some nice overviews, deep dives and demos of Brigade on YouTube which I think are worth referencing on the site.

Screen Shot 2021-11-22 at 1 12 45 PM

  • Talk about the speed and efficiency of Brigade

I added a short paragraph here trying to talk about what seems like one of the project's key standout features, but we don't really talk about it very much. I think it would be nice to talk about the way Brigade 2 is built to handle large streams of events and works to process jobs very very quickly. But I need some help and input on hopw best to communicate this.

  • Consolidate links and points of engagement (aka the mega-footer)

Screen Shot 2021-11-22 at 1 12 23 PM

This is hopefully a decent start on re-framing the project's value prop and showing the new cool stuff in v2, but I would love some input on how I can better articulate this stuff!

@netlify
Copy link

netlify bot commented Nov 22, 2021

✔️ Deploy Preview for v2-brigade ready!

🔨 Explore the source changes: d57f937

🔍 Inspect the deploy log: https://app.netlify.com/sites/v2-brigade/deploys/61df0fdabb2f670008fc22ba

😎 Browse the preview: https://deploy-preview-55--v2-brigade.netlify.app

@krancour
Copy link
Contributor

krancour commented Nov 22, 2021

@flynnduism this is amazing. And the background animation is mesmerizing. It's literally fun just to scroll. But it's not fun just for fun's sake -- I feel like that animation really represents what Brigade does. Awesome!

@krancour
Copy link
Contributor

krancour commented Nov 22, 2021

A couple notes about content:

  • The video is pretty old and v1-oriented. I'm recording an on-demand webinar for CNCF tomorrow. That video might be a better one to use here.

  • There's a mention of events from Trello somewhere on the page. We should probably strike that. While a Trello gateway is 100% possible, we don't have one now, so I'd hate for it to look like a false claim.

  • The example of "updating a CosmosDB database" might hit harder if it were "updating a MongoDB Database."

  • The example of "sending a Slack message" actually depicts handling an event from Slack, which I think is better, honestly, but the name of the example probably should be updated.

cc @vdice

@flynnduism
Copy link
Collaborator Author

flynnduism commented Nov 23, 2021 via email

Copy link
Contributor

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so great, @flynnduism ! 👏

Stoked as well on the vastly simplified build approach and slimmed-down dependency tree.

index.html Outdated
</li>
<li class="slide-trigger">
<label for="img-2" id="img-dot-2">
<img src="assets/images/ex-icon-07.png" /> Update a CosmosDB database
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="assets/images/ex-icon-07.png" /> Update a CosmosDB database
<img src="assets/images/ex-icon-07.png" /> Update a MongoDB database

(per #55 (comment))

index.html Outdated
</li>
<li class="slide-trigger">
<label for="img-3" id="img-dot-3">
<img src="assets/images/ex-icon-05.png" /> Send a Slack message
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<img src="assets/images/ex-icon-05.png" /> Send a Slack message
<img src="assets/images/ex-icon-05.png" /> Handle a Slack message event

(per #55 (comment))

index.html Outdated

<p>Brigade can be used to chain containers together to build processing pipelines.</p>
<ul class="fancy">
<li>Watch for incoming requests from services like GitHub, Docker, and Trello</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Watch for incoming requests from services like GitHub, Docker, and Trello</li>
<li>Watch for incoming requests from services like GitHub, Docker, and BitBucket</li>

(per #55 (comment))

@krancour
Copy link
Contributor

Here's a new YouTube video we can use: https://www.youtube.com/watch?v=EqJ9_k56Q3U

@krancour
Copy link
Contributor

krancour commented Dec 1, 2021

Just wanted to check if this is close to mergeable. v2 has gone GA this afternoon.

@flynnduism
Copy link
Collaborator Author

@krancour congratulations! I will apply these edits and feedback items today to get this finalized asap!

@krancour
Copy link
Contributor

krancour commented Dec 1, 2021

Thanks @flynnduism!

@flynnduism
Copy link
Collaborator Author

@krancour @vdice I've updated this PR with the suggested content edits and some minor design cleanups.
Ready for some 👀


CICD Note: the netlify config for the site will not pass this PR, as the command to build the site needs to change for the new (non-jekyll) tooling. You can preview the build properly here https://v2.brigade.sh/

Build command will change from:

gulp && bundle exec jekyll build

to:

yarn parcel index.html

@krancour
Copy link
Contributor

krancour commented Dec 2, 2021

@flynnduism this looks great!

I do notice some elements overlapping in ways that I don't think were intended. Example:

Screen Shot 2021-12-02 at 4 05 51 PM

And the overlapping is a bit different in different browsers. Ugh. I had hoped the days of browsers rendering sites differently were mostly behind us.

@krancour
Copy link
Contributor

@flynnduism just wanted to follow up. Are we close on this?

@radu-matei
Copy link
Contributor

radu-matei commented Dec 17, 2021

Super-nit that can be totally ignored until a later time — it would be great if we had some basic syntax highlighting for the examples on the main page.
(I've been using hljs for a while for my posts and it works well enough for me.)

image

@flynnduism
Copy link
Collaborator Author

flynnduism commented Dec 22, 2021

@krancour I've pushed layout changes for the various mobile and desktop states, to fix the issue where some of the content panels overlapped each other.

@krancour
Copy link
Contributor

krancour commented Dec 23, 2021

A lot of the Netlify checks are failing. I suspect the recent move to CNCF's Netlify account may have something to do with it. I'll volunteer to investigate that.

@flynnduism
Copy link
Collaborator Author

@krancour the test fails here are to be expected, as the v1 site checks here are expecting jekyll build to pass - this branch removes Jekyll and uses yarn parcel index.html to build the site instead.

This PR can be tested at a different location (v2.brigade.sh), and if it looks good to ship the Netlify build command can be swapped out for the prod instance of the website.

@krancour
Copy link
Contributor

krancour commented Jan 6, 2022

@flynnduism it looks like this needs to be rebased on the v2 branch. There aren't actually any conflicts. I'd do it myself, but I can't push to your branch.

After that, if you also think this is ready, LGTM.

I'll straighten out Netlify to deploy the v2 branch to v2.brigade.sh and if all looks good still, we can PR v2 to main and we'll be done.

Edit: I did deploy this already to https://v2.brigade.sh for anyone who wants to preview it.

@krancour
Copy link
Contributor

@flynnduism, alternatively, I can do the rebase if you check the "Allow edits and access to secrets by maintainers" box on the PR.

dependabot bot and others added 3 commits January 12, 2022 09:22
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.11.4 to 1.12.5.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.11.4...v1.12.5)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
* for a one page site jekyll is overkill
* changes this from a static site to a simple index.html
* use parcel.js to handle the scss to css compilation
* this removes the need for ruby, bundler, gulp and most packages

Signed-off-by: flynnduism <[email protected]>
@flynnduism
Copy link
Collaborator Author

Rebase is in @krancour, sorry for the delay. Ready for 👀

@krancour krancour merged commit d9ccc28 into brigadecore:v2 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants