-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Auto-delete-input-file deleting input even in error case #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgkoester
force-pushed
the
fix-auto-delete-input-file-on-error-case
branch
from
December 18, 2024 09:17
2a8995c
to
0b51e97
Compare
In CT-2136 it was decided to delete jobs in more situations, and use it for cancelling the server-side processing in case for example of CTRL+C cancellations on the client side.
Github is no longer supporting building with/for python 3.7.
We still need to increase the version to 10 due to backwards compatibility drop of dropping python. Should I give it a try? |
pkern90
previously approved these changes
Dec 19, 2024
Major version jump due to discontinued support for Python version 3.7.
FelixMertin
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as only dev dependencies, lock file and version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input files are currently deleted even if there are processing errors and exceptions.
This needs fixing.