Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Auto-delete-input-file deleting input even in error case #111

Merged
merged 9 commits into from
Dec 20, 2024

Conversation

georgkoester
Copy link
Contributor

Input files are currently deleted even if there are processing errors and exceptions.
This needs fixing.

@georgkoester georgkoester force-pushed the fix-auto-delete-input-file-on-error-case branch from 2a8995c to 0b51e97 Compare December 18, 2024 09:17
In CT-2136 it was decided to delete jobs in more situations,
and use it for cancelling the server-side processing in case
for example of CTRL+C cancellations on the client side.
Github is no longer supporting building with/for python 3.7.
@georgkoester georgkoester requested a review from pkern90 December 19, 2024 07:29
@georgkoester
Copy link
Contributor Author

We still need to increase the version to 10 due to backwards compatibility drop of dropping python. Should I give it a try?

pkern90
pkern90 previously approved these changes Dec 19, 2024
Major version jump due to discontinued support
for Python version 3.7.
Copy link
Contributor

@FelixMertin FelixMertin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as only dev dependencies, lock file and version.

@georgkoester georgkoester merged commit 64d98eb into main Dec 20, 2024
9 checks passed
@georgkoester georgkoester deleted the fix-auto-delete-input-file-on-error-case branch December 20, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants