New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docstrings to NumPy standard (`importers`) #166

Merged

michaelweinold merged 3 commits into brightway-lca:documentation_improvements from ShanikaNishadhi:swdocumentation_improvements

Mar 19, 2023

ShanikaNishadhi commented Mar 16, 2023

Convert following files to num py docstring standards

init__.py
ecospold1_lcia.py
ecospold2_biosphere.py
excel_lcia.py
json_ld_lcia.py
simapro_lcia_csv.py


          Convert to num py docstring standards

7a8e077

Author

ShanikaNishadhi commented Mar 16, 2023

@michaelweinold Could you please review this PR?

michaelweinold self-assigned this

michaelweinold reviewed

View reviewed changes

bw2io/importers/__init__.py Outdated Show resolved Hide resolved

michaelweinold reviewed

View reviewed changes

bw2io/importers/excel_lcia.py Show resolved Hide resolved

michaelweinold reviewed

View reviewed changes

bw2io/importers/excel_lcia.py Show resolved Hide resolved

michaelweinold reviewed

View reviewed changes

bw2io/importers/simapro_lcia_csv.py Outdated Show resolved Hide resolved

michaelweinold reviewed

View reviewed changes

bw2io/importers/ecospold2_biosphere.py Show resolved Hide resolved

michaelweinold reviewed

View reviewed changes

bw2io/importers/simapro_lcia_csv.py Show resolved Hide resolved

Contributor

michaelweinold commented Mar 16, 2023

Nice, nice, nice! Some minor revisions need to be made (compare my comments in the code). Many thanks!


          Resolve PR comments

136c40c

Author

ShanikaNishadhi commented Mar 17, 2023

@michaelweinold I have resolved the PR comments with a new commit 136c40c
Can you please have a look?

michaelweinold changed the title ~~Convert to num py docstring standards~~ Update docstrings to NumPy standard

michaelweinold added the documentation label


          Remove unnecessary comments

a3d8ef4

michaelweinold merged commit 551431e into brightway-lca:documentation_improvements

michaelweinold changed the title ~~Update docstrings to NumPy standard~~ Update docstrings to NumPy standard (importers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels