-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docstrings to NumPy standard (extractors/ecospold*
, extractors/simapro*
)
#176
Merged
michaelweinold
merged 8 commits into
brightway-lca:main
from
writesbytes:documentation_improvements
Apr 5, 2023
Merged
Update docstrings to NumPy standard (extractors/ecospold*
, extractors/simapro*
)
#176
michaelweinold
merged 8 commits into
brightway-lca:main
from
writesbytes:documentation_improvements
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelweinold
changed the title
Documentation improvements
Update docstrings to NumPy standard (Mar 30, 2023
extractors
)
michaelweinold
changed the title
Update docstrings to NumPy standard (
Update docstrings to NumPy standard (Mar 31, 2023
extractors
)extractors/ecospold1
)
@writesbytes, great work overall. Some minor comments added. |
michaelweinold
changed the title
Update docstrings to NumPy standard (
Update docstrings to NumPy standard (Apr 4, 2023
extractors/ecospold1
)extractors/ecospold*
, extractors/simapro*
)
writesbytes
commented
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit docstrings based on received feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docstrings in ecospold1.py, ecospold2.py, simapro_csv.py, and simapro_lcia_csv.py