Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstrings to NumPy standard (extractors/ecospold*, extractors/simapro*) #176

Merged

Conversation

writesbytes
Copy link
Contributor

Update docstrings in ecospold1.py, ecospold2.py, simapro_csv.py, and simapro_lcia_csv.py

@michaelweinold michaelweinold changed the title Documentation improvements Update docstrings to NumPy standard (extractors) Mar 30, 2023
@michaelweinold michaelweinold self-assigned this Mar 30, 2023
@michaelweinold michaelweinold changed the title Update docstrings to NumPy standard (extractors) Update docstrings to NumPy standard (extractors/ecospold1) Mar 31, 2023
@michaelweinold
Copy link
Contributor

@writesbytes, great work overall. Some minor comments added.

@michaelweinold michaelweinold changed the title Update docstrings to NumPy standard (extractors/ecospold1) Update docstrings to NumPy standard (extractors/ecospold*, extractors/simapro*) Apr 4, 2023
Copy link
Contributor Author

@writesbytes writesbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit docstrings based on received feedback.

@michaelweinold michaelweinold merged commit d02b7ff into brightway-lca:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants