Fix macOS build problem due to new LZ4 release #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently-observed build breakage on macOS was due to a new version of the LZ4 library. I suppose the fancier thing to do would be to try to lock in a specific LZ4 version or make the Makefile flexible to different release versions as they come out. But for now I'm just happy to force this to work again.
Not related, but some housecleaning I took care of at the same time: While I was in there, I noticed a warning because the Actions we'd used for Google Cloud are being deprecated. That's when I noticed that we're not even using Google Cloud in these workflows anymore, so for now I've just chosen to remove them.