Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Implement -U (single instance) option for BSD & MacOS #2072

Open
4 of 8 tasks
Caellian opened this issue Nov 7, 2024 · 1 comment
Open
4 of 8 tasks

[Feature]: Implement -U (single instance) option for BSD & MacOS #2072

Caellian opened this issue Nov 7, 2024 · 1 comment
Labels
feature suggest addition of new functionality that isn't currently supported in any way good first issue straightforward enough for first-time contributors to be able to implement themselves help wanted functionality with which contributors need help to implement/fix properly os: dragonfly related to DragonFly BSD os: macos related to MacOS os: openbsd related to OpenBSD os: solaris related to Solaris OS

Comments

@Caellian
Copy link
Collaborator

Caellian commented Nov 7, 2024

With #2049 merged, conky now supports -U option on Linux which makes it exit early if it detects another instance running. This feature requires a separate implementation for other platforms as they keep track of running processes differently.

I'm opening this tracking issue to track progress on support for other platforms Conky can currently run on.

Following platforms are currently supported:

  • Linux
  • BSD
    • DragonFly
    • FreeBSD
    • NetBSD
    • OpenBSD
  • Haiku
  • MacOS
  • Solaris

If you're interested, open a PR and mention this issue (just don't use "closes" phrasing) so it shows up here. Once support for all platforms is implemented this issue will be closed.

@Caellian Caellian added help wanted functionality with which contributors need help to implement/fix properly good first issue straightforward enough for first-time contributors to be able to implement themselves feature suggest addition of new functionality that isn't currently supported in any way os: macos related to MacOS os: freebsd related to FreeBSD os: dragonfly related to DragonFly BSD os: netbsd related to NetBSD os: openbsd related to OpenBSD os: solaris related to Solaris OS labels Nov 7, 2024
g0mb4 added a commit to g0mb4/conky that referenced this issue Nov 13, 2024
Tested on FreeBSD 14.1.
Takes part of brndnmtthws#2072.
brndnmtthws pushed a commit that referenced this issue Nov 13, 2024
Tested on FreeBSD 14.1.
Takes part of #2072.
@g0mb4

This comment was marked as outdated.

@Caellian Caellian removed os: netbsd related to NetBSD os: freebsd related to FreeBSD labels Nov 13, 2024
g0mb4 added a commit to g0mb4/conky that referenced this issue Nov 14, 2024
This patch also fixes a compilation error on Haiku.

Compiled with `cmake -DBUILD_X11=FALSE ..`

Tested on Haiku-r1beta5.
Takes part of brndnmtthws#2072.
brndnmtthws pushed a commit that referenced this issue Nov 29, 2024
* Implement `-U` for Haiku.

This patch also fixes a compilation error on Haiku.

Compiled with `cmake -DBUILD_X11=FALSE ..`

Tested on Haiku-r1beta5.
Takes part of #2072.

* Revert `common.cc`.

A cross-platform solution is already implemented in #2080.
This PR will be rebased *after* the OpenBSD fix was merged.

* Haiku: Remove `wordexp.h`.

Use the `to_real_path()` used for OpenBSD.

* Haiku: Remove `HAIKU_HOME_DIR`.

It was not used.
@Caellian Caellian added the os: netbsd related to NetBSD label Dec 8, 2024
g0mb4 added a commit that referenced this issue Dec 11, 2024
Tested on NetBSD 10.
Takes part of #2072.
g0mb4 added a commit that referenced this issue Dec 11, 2024
Tested on NetBSD 10.
Takes part of #2072.
@g0mb4 g0mb4 removed the os: netbsd related to NetBSD label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature suggest addition of new functionality that isn't currently supported in any way good first issue straightforward enough for first-time contributors to be able to implement themselves help wanted functionality with which contributors need help to implement/fix properly os: dragonfly related to DragonFly BSD os: macos related to MacOS os: openbsd related to OpenBSD os: solaris related to Solaris OS
Projects
None yet
Development

No branches or pull requests

2 participants