Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose runtime attributes in AnnotateVcf #255

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

epiercehoffman
Copy link
Collaborator

Updates

Expose runtime attributes in AnnotateVcf.wdl and subworkflows. Requested by an internal user who ran out of memory in AnnotateVcf.AnnotateExternalAF.split_query_vcf and was not able to increase the memory in Terra.

Testing

  • Validated AnnotateVcf.wdl with womtool.
  • Did not run a test because we lack test data for AnnotateVcf.wdl in the repo, but I have another PR coming soon that will hopefully address that, and the user can also test the fix and report back.

Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't see any areas where there would be errors at runtime, so validating with womtool should be fine here.

@epiercehoffman epiercehoffman merged commit 7157a5e into master Nov 15, 2021
@mwalker174 mwalker174 deleted the eph_expose_annotatevcf_runtime_attr branch March 2, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants