Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VCFs in AnnotateVcf test JSON #256

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

epiercehoffman
Copy link
Collaborator

@epiercehoffman epiercehoffman commented Nov 15, 2021

Updates

Generated a new clean VCF from MakeCohortVcf with test_large data and added to test_large input_values JSON. Use this VCF and index file as inputs to AnnotateVcf test JSON in place of an internal dataset.

  • Note that a new clean VCF was needed because the baseline_cleaned_vcf contained MCNV records which broke AnnotateVcf.
  • Note that the number of JSONs to validate is reduced to 42 from 43 after this change, because an AnnotateVcf JSON is only created for test_large, not test_small, which doesn't have a clean_vcf attribute.

Testing

  • Validated all WDLs and JSONs
  • AnnotateVcf.wdl ran successfully with the new input files

@mwalker174
Copy link
Collaborator

While you're in there, can you move everything from gs://talkowskicromwellresults into gs://gatk-sv-resources?

@epiercehoffman
Copy link
Collaborator Author

epiercehoffman commented Nov 15, 2021

I moved the cohort depth and PESR test_large VCFs, and the other files were former inputs to RegenotypeCNVs/Module04b so I just deleted them from the test_large input values JSON. I didn't clean out the gs://talkowskicromwellresults bucket itself though because there's a lot of stuff in there.

*Edit: Re-ran womtool validation after latest commit & it was successful

@epiercehoffman epiercehoffman merged commit 0bded98 into master Nov 15, 2021
@mwalker174 mwalker174 deleted the eph_add_annotatevcf_test_json branch March 2, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants