Build and deploy docker images. #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VJalili
force-pushed
the
push_docker_images
branch
from
3024ccf to
2d860f2
Compare
mwalker174
requested changes
Dec 9, 2021
There was a problem hiding this comment.
Thank you @VJalili this is really excellent! And very well documented as well. I have mostly minor grammatical suggestions.
Co-authored-by: Mark Walker <[email protected]>
Co-authored-by: Mark Walker <[email protected]>
Co-authored-by: Mark Walker <[email protected]>
Co-authored-by: Mark Walker <[email protected]>
Co-authored-by: Mark Walker <[email protected]>
Co-authored-by: Mark Walker <[email protected]>
Co-authored-by: Mark Walker <[email protected]>
Co-authored-by: Mark Walker <[email protected]>
Co-authored-by: Mark Walker <[email protected]>
Co-authored-by: Mark Walker <[email protected]>
Co-authored-by: Mark Walker <[email protected]>
Co-authored-by: Mark Walker <[email protected]>
mwalker174
approved these changes
Jan 4, 2022
|
@mwalker174 Thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors and updates the GitHub actions for building docker images as follows.
test_build) into two jobs:build_args_job: this job determines the images to be built (based on the delta between two commit SHAs) and composes a tag to be used for the images;build_job: this job will run for pull requests (PR) only (i.e., it will be triggered only when a commit is pushed to an open PR), and it will only test if the determined target images are built successfully.publish_job, which is run only when a commit is pushed to themasterbranch (e.g., merging the PR). This job builds the images and pushes them to Google cloud Container Registry (GCR). This job runs in theDeployenvironment that contains encrypted GCP service account credentials required to push images to GCR. The job usesgcloudto configure Docker credentials. The execution of this job is paused until its execution is approved by the maintainers.