Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External AF SVID INFO key is String type #283

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

epiercehoffman
Copy link
Collaborator

Updates

Tweaks to AnnotateVcf workflow:

  • SVID INFO key from AnnotateExternalAF should be a String type, not Float. This was causing issues with Hail
    • There are two ModifyVcf tasks, one in AnnotateExternalAF and one in AnnotateExternalAFPerContig. It appears that only the one in the per-contig WDL is used, but I updated both because they aren't identical so I was wary of deleting the other
  • Output name of annotated VCF was {prefix}.annotated.vcf.vcf.gz; removed extra .vcf
  • Spacing

Testing

  • Validated all WDLs and JSONs with womtool
  • Tested AnnotateVcf and verified that the output VCF name had one .vcf and the header reflected that the SVID INFO key is of type String

Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks fine to me!

@epiercehoffman epiercehoffman merged commit aa6e2a0 into master Jan 14, 2022
@epiercehoffman epiercehoffman deleted the eph_external_af_header_string branch April 22, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants