Make manta region bed index required #635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manta workflow fails if the index file does not exist; hence, following the discussion in #578, we are making this input required. Specifically:
The workflow fails to evaluate
vm_disk_size
and results inEXECUTOR_ERROR
on CoA, which, since it occurs at the TES level, is a more challenging error to debug than task-level errors.The alternative approach to the changes implemented in this PR is to adjust the
vm_disk_size
calculation to exclude the index file size from the calculation (which would not impact much since the file is small). The main drawback of this approach is that the/usr/local/bin/manta/bin/configManta.py
script may fail if the optional file does not exist. Hence, making the file required seems a better option.