Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make manta region bed index required #635

Merged

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Feb 2, 2024

The manta workflow fails if the index file does not exist; hence, following the discussion in #578, we are making this input required. Specifically:

The workflow fails to evaluate vm_disk_size and results in EXECUTOR_ERROR on CoA, which, since it occurs at the TES level, is a more challenging error to debug than task-level errors.

The alternative approach to the changes implemented in this PR is to adjust the vm_disk_size calculation to exclude the index file size from the calculation (which would not impact much since the file is small). The main drawback of this approach is that the /usr/local/bin/manta/bin/configManta.py script may fail if the optional file does not exist. Hence, making the file required seems a better option.

# This file is required by the workflow as it fails if the file was not present.
@VJalili VJalili requested a review from mwalker174 February 2, 2024 15:31
@VJalili VJalili marked this pull request as ready for review February 2, 2024 15:31
Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - the coding was a unnecessarily awkward. Do you want to do the same thing for the reference_index input also?

@VJalili
Copy link
Member Author

VJalili commented Feb 2, 2024

Thank you, @mwalker174, for the prompt review!!

Do you want to do the same thing for the reference_index input also?

Yes, I will update that next.

@VJalili VJalili merged commit 0cad166 into broadinstitute:main Feb 2, 2024
2 checks passed
@VJalili VJalili deleted the manta-region-bed-index-required branch February 2, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants