Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sv_pipeline_hail_docker with sv_pipeline_docker #638

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Replace sv_pipeline_hail_docker with sv_pipeline_docker #638

merged 2 commits into from
Apr 29, 2024

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Feb 8, 2024

A follow up from #634 & #633

Similar to #634:

  • if a workflow has both sv_pipeline_hail_docker and sv_pipeline_docker, then remove sv_pipeline_hail_docker and replace all runtime docker image references with sv_pipeline_docker;
  • if the workflow does not have sv_pipeline_docker in its inputs, replace sv_pipeline_hail_docker with sv_pipeline_docker.

@VJalili VJalili marked this pull request as ready for review February 8, 2024 00:31
@VJalili VJalili mentioned this pull request Feb 8, 2024
Merged
@VJalili VJalili changed the title Replace hail docker with sv-pipeline image. Replace sv_pipeline_hail_docker with sv_pipeline_docker Feb 8, 2024
@VJalili VJalili requested a review from mwalker174 February 14, 2024 18:16
mwalker174
mwalker174 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Unfortunately you're going to have to rebase with some conflicts at this point, but as long as it passes womtool/miniwdl validation you're good to go.

@VJalili
Merge remote-tracking branch 'upstream/main' into remove_hail_docker
e1a4dd1 
# Conflicts:
#	inputs/values/dockers.json
#	inputs/values/dockers_azure.json
@VJalili
Copy link
Member Author

VJalili commented Apr 29, 2024

Thanks, @mwalker174!

@VJalili VJalili merged commit bd0535b into broadinstitute:main Apr 29, 2024
2 checks passed
@VJalili VJalili deleted the remove_hail_docker branch April 29, 2024 17:52
@VJalili VJalili mentioned this pull request Apr 30, 2024
Open
@mwalker174 mwalker174 mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwalker174 mwalker174 mwalker174 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VJalili @mwalker174