Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sv_pipeline_rdtest_docker with sv_pipeline_docker. #645

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Feb 14, 2024

A follow-up from #633, similar to #634 and #639.

This PR improves input definition by collapsing identical inputs defined by different variables and decreasing the number of inputs the workflows take. Specifically, it implements the following changes:

  • Replace all the references to sv_pipeline_rdtest_docker with sv_pipeline_docker; and,
  • Remove sv_pipeline_rdtest_docker if sv_pipeline_docker is also among the inputs to the workflow.

@VJalili VJalili requested a review from mwalker174 February 14, 2024 18:16
@MattWellie
Copy link
Contributor

very happy this is being addressed

VJalili added 2 commits April 30, 2024 10:52
# Conflicts:
#	inputs/values/dockers.json
#	inputs/values/dockers_azure.json
#	wdl/GATKSVPipelineBatch.wdl
#	wdl/GATKSVPipelineSingleSample.wdl
#	wdl/GenotypeComplexVariants.wdl
#	wdl/MakeCohortVcf.wdl
#	wdl/ScatterCpxGenotyping.wdl
@VJalili VJalili merged commit a42dfeb into broadinstitute:main Apr 30, 2024
2 checks passed
@VJalili VJalili deleted the remove_rdtest_docker branch April 30, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants