Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SampleQC and Batching notebooks #744

Merged
merged 17 commits into from
Jan 8, 2025

Conversation

kjaisingh
Copy link
Collaborator

This PR introduces the initial set of SampleQC and Batching notebooks part of the featured workspace into the GATK-SV repository to enable fine-grained source control. They have been added to the newly-created scripts/notebooks/ directory.

@kjaisingh kjaisingh added the enhancement New feature or request label Nov 5, 2024
@kjaisingh kjaisingh self-assigned this Nov 5, 2024
Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! I've only had a chance to go through the QC notebook so far and my only broad comment is to document the figures so they are all clearly explained.

scripts/notebooks/SampleQC.ipynb Show resolved Hide resolved
scripts/notebooks/SampleQC.ipynb Outdated Show resolved Hide resolved
scripts/notebooks/SampleQC.ipynb Outdated Show resolved Hide resolved
scripts/notebooks/SampleQC.ipynb Outdated Show resolved Hide resolved
scripts/notebooks/SampleQC.ipynb Outdated Show resolved Hide resolved
scripts/notebooks/SampleQC.ipynb Outdated Show resolved Hide resolved
scripts/notebooks/SampleQC.ipynb Outdated Show resolved Hide resolved
scripts/notebooks/SampleQC.ipynb Outdated Show resolved Hide resolved
scripts/notebooks/SampleQC.ipynb Outdated Show resolved Hide resolved
scripts/notebooks/SampleQC.ipynb Outdated Show resolved Hide resolved
Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your updates. I moved on to the Batching notebook but ran into a problem, see below.

scripts/notebooks/Batching.ipynb Outdated Show resolved Hide resolved
scripts/notebooks/Batching.ipynb Outdated Show resolved Hide resolved
scripts/notebooks/SampleQC.ipynb Outdated Show resolved Hide resolved
scripts/notebooks/SampleQC.ipynb Outdated Show resolved Hide resolved
scripts/notebooks/Batching.ipynb Show resolved Hide resolved
scripts/notebooks/Batching.ipynb Outdated Show resolved Hide resolved
scripts/notebooks/Batching.ipynb Show resolved Hide resolved
Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your work on this @kjaisingh @epiercehoffman @shadizaheri

@kjaisingh kjaisingh merged commit ca6ffad into main Jan 8, 2025
5 checks passed
@kjaisingh kjaisingh deleted the kj_featured_workspace_notebooks branch January 8, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants