Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace relative paths with abs paths to JS components #747

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Nov 12, 2024

Relative paths used for referencing components break version docs, so I am replacing them with ABS paths for portability.

This change is needed for versioning docs since the relative path does not resolve to the correct path on versioned copies of these markdowns.

@VJalili VJalili added the documentation Improvements or additions to documentation label Nov 12, 2024
@VJalili VJalili requested a review from mwalker174 November 12, 2024 18:47
Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me!

@VJalili
Copy link
Member Author

VJalili commented Nov 13, 2024

Thanks, @mwalker174!

@VJalili VJalili merged commit 1d78766 into broadinstitute:main Nov 13, 2024
3 checks passed
@VJalili VJalili deleted the docs-abs-path branch November 13, 2024 14:36
CuriousTim pushed a commit to CuriousTim/gatk-sv that referenced this pull request Nov 15, 2024
…e#747)

* Replace relative path with abs path to the component.

* Make abs path more portable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants