Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back MELT inputs to EvidenceQC Terra json #772

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

epiercehoffman
Copy link
Collaborator

Updates:
This PR reverts a change from #763. The Terra JSONs are meant to be configured such that switching out raw callers requires editing inputs for GatherSampleEvidence only. All other workflows should look for any caller-specific inputs that are present, and if an input is empty, the workflows are designed to ignore it. This PR adds back MELT-specific inputs to the Terra EvidenceQC JSON template so that if users do configure MELT, those inputs will not be ignored during EvidenceQC.

Testing:

  • Validated EvidenceQC Terra JSON with Terra validation script
  • Tested EvidenceQC with updated input parameters in a workspace with no MELT files and it ran and produced output as expected

@epiercehoffman epiercehoffman merged commit 7d4a014 into main Jan 28, 2025
6 checks passed
@epiercehoffman epiercehoffman deleted the eph_eqc_melt_scramble branch January 28, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants