-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mutect3 dataset generation to Mutect2 WDL #7992
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takutosato
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup looks good!
Thanks! I'll just fix the womtool failure on the pon WDL now. |
Codecov Report
@@ Coverage Diff @@
## master #7992 +/- ##
===============================================
+ Coverage 79.301% 86.659% +7.358%
- Complexity 36613 38769 +2156
===============================================
Files 2328 2328
Lines 181684 181685 +1
Branches 19950 19952 +2
===============================================
+ Hits 144077 157447 +13370
+ Misses 30805 17240 -13565
- Partials 6802 6998 +196
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, this PR removes Funcotator (these workflows don't need to be coupled),a bunch of code that juggles file names, and some obsolete and clunky means of handling defaults from the Mutect2 WDL. Also, it deletes the mutect2 multi-sample WDL which Terra renders unnecessary.
@takutosato Do you have time for one last code review?