Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS-1514 backwards compatibility #9049

Merged
merged 14 commits into from
Nov 25, 2024

Conversation

gbggrant
Copy link
Collaborator

@gbggrant gbggrant commented Nov 19, 2024

This PR makes the GvsPrepareRangesCallset wdl backwards compatible with older (well, at least Delta) call sets.

  • It checks for the call_PS column in the vet table and if present uses phasing columns. If not present (as in Delta) does NOT include phasing.

Successful run again Delta data here
Successful integration test run here

- With Echo we added phasing support. This PR adds code to check if the VET table(s) contain phasing information (well, PS) and allows phasing-related data to be extracted if present, otherwise doesn't include that (missing) data.
@gbggrant gbggrant requested a review from mcovarr November 20, 2024 22:24
@gbggrant
Copy link
Collaborator Author

@mcovarr - I have added the validation for V1 or V2 into the python script

Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbggrant gbggrant merged commit 4e77e09 into ah_var_store Nov 25, 2024
16 of 17 checks passed
@gbggrant gbggrant deleted the gg_VS-1514_BackwardsCompatibility branch November 25, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants