Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix curate input array files [VS-1490] #9054

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Nov 25, 2024

Successful integration run here.

Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gbggrant gbggrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops again.

@@ -336,7 +336,7 @@ task LoadData {

## now we want to create a sub list of these samples (without the ones that have already been loaded)

python3 /gatk/scripts/variantstore/wdl/extract/curate_input_array_files.py \
python3 /gatk/scripts/variantstore/scripts/curate_input_array_files.py \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn. How did this even work after my refactoring. I know I ran the integration tests.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old image still worked because the script was where the WDL expected it to be.

@mcovarr mcovarr merged commit 6daaa57 into ah_var_store Nov 25, 2024
20 of 21 checks passed
@mcovarr mcovarr deleted the vs_1490_fix_curate_input_array_files branch November 25, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants