Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Variant Calling #1464

Merged

Conversation

jessicaway
Copy link
Member

Description

Give your PR a concise yet descriptive title.
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Mention any issues fixed, addressed, or otherwise related to this pull request, including issue numbers or hard links for issues in other repos.
You can delete these instructions once you have written your PR description.


Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

@jessicaway jessicaway changed the title Testing Varian Calling Testing Variant Calling Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Remember to squash merge!

Copy link

github-actions bot commented Jan 6, 2025

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jan 6, 2025

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

…ant_calling_test

# Conflicts:
#	.dockstore.yml
Copy link

github-actions bot commented Jan 7, 2025

Remember to squash merge!

Copy link

github-actions bot commented Jan 7, 2025

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

github-actions bot commented Jan 7, 2025

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

@jessicaway jessicaway changed the base branch from develop to np_jw_test_illumina_genotyping_arrays January 7, 2025 19:27
Copy link
Contributor

@nikellepetrillo nikellepetrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@jessicaway jessicaway merged commit 4984196 into np_jw_test_illumina_genotyping_arrays Jan 8, 2025
16 of 19 checks passed
@jessicaway jessicaway deleted the jw_add_variant_calling_test branch January 8, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants