Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed full file path in results #10

Merged
merged 1 commit into from
Aug 20, 2014
Merged

Embed full file path in results #10

merged 1 commit into from
Aug 20, 2014

Conversation

bcardarella
Copy link
Contributor

In order for ember-cli's livereload to know the full file path
broccoli-sane-watcher needs to pass back that filePath in the results
hash. sane-0.6.0 has been updated to provide the root of the file path.

In order for ember-cli's livereload to know the full file path
broccoli-sane-watcher needs to pass back that filePath in the results
hash. sane-0.6.0 has been updated to provide the root of the file path.
@stefanpenner
Copy link
Collaborator

LGTM @krisselden if it looks good to you merge, and i can cut the new release.

@stefanpenner
Copy link
Collaborator

@krisselden ping

1 similar comment
@stefanpenner
Copy link
Collaborator

@krisselden ping

@rwjblue
Copy link
Member

rwjblue commented Aug 20, 2014

LGTM

krisselden added a commit that referenced this pull request Aug 20, 2014
@krisselden krisselden merged commit b975eed into broccolijs:master Aug 20, 2014
@bcardarella bcardarella deleted the bc-embed-full-file-path-in-results branch August 20, 2014 11:39
@bcardarella
Copy link
Contributor Author

@krisselden thank you!

@stefanpenner
Copy link
Collaborator

@bcardarella i pushed the new version to npm so you should be good to go.

@krisselden
Copy link
Collaborator

@bcardarella what happens if multiple file changes caused the build? does live reload need to know of all of them?

@bcardarella
Copy link
Contributor Author

Is that even possible? I did not see anywhere in sane that it tracked and consolidated multiple file system changes into a single collection

@rwjblue
Copy link
Member

rwjblue commented Sep 7, 2014

@bcardarella - broccoli-sane-watcher debounces the rebuild (so that things like git checkout master do not cause a rebuild for each file changed). So it absolutely possible that multiple changes were made between rebuilds.

@bcardarella
Copy link
Contributor Author

@rwjblue I didn't say that. I said that sane itself doesn't seem to consolidate them. The scope of the original request seems well outside of this PR

@bcardarella
Copy link
Contributor Author

@rwjblue wait, were you getting at that broccoli-sane-watcher should cache the path on a debounce then collect there and purge cache after?

@rwjblue
Copy link
Member

rwjblue commented Sep 7, 2014

yes

@bcardarella
Copy link
Contributor Author

@rwjblue that makes sense. I'll see about getting this done. Thanks for pointing me in that direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants