-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed full file path in results #10
Embed full file path in results #10
Conversation
In order for ember-cli's livereload to know the full file path broccoli-sane-watcher needs to pass back that filePath in the results hash. sane-0.6.0 has been updated to provide the root of the file path.
LGTM @krisselden if it looks good to you merge, and i can cut the new release. |
@krisselden ping |
1 similar comment
@krisselden ping |
LGTM |
…sults Embed full file path in results
@krisselden thank you! |
@bcardarella i pushed the new version to npm so you should be good to go. |
@bcardarella what happens if multiple file changes caused the build? does live reload need to know of all of them? |
Is that even possible? I did not see anywhere in sane that it tracked and consolidated multiple file system changes into a single collection |
@bcardarella - broccoli-sane-watcher debounces the rebuild (so that things like |
@rwjblue I didn't say that. I said that sane itself doesn't seem to consolidate them. The scope of the original request seems well outside of this PR |
@rwjblue wait, were you getting at that broccoli-sane-watcher should cache the path on a debounce then collect there and purge cache after? |
yes |
@rwjblue that makes sense. I'll see about getting this done. Thanks for pointing me in that direction. |
In order for ember-cli's livereload to know the full file path
broccoli-sane-watcher needs to pass back that filePath in the results
hash. sane-0.6.0 has been updated to provide the root of the file path.