-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge updates from Prettier 2.1.x (Prettier 2.1.0) #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cleanup js `loc.js` * Simplify `composeLoc` * Simplify `locEnd` * Simplify * Fix Ast * Remove use of loc * Remove use of loc
* Build(deps): Bump @babel/parser from 7.10.3 to 7.10.4 Bumps [@babel/parser](https://github.com/babel/babel/tree/HEAD/packages/babel-parser) from 7.10.3 to 7.10.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.10.4/packages/babel-parser) Signed-off-by: dependabot[bot] <[email protected]> * Add `delete obj?.#x.a` test * Add new `tuple` and `record` tests. Fix old test * Fix test Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: fisker <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.0.7 to v1.0.10. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Commits](codecov/codecov-action@v1.0.7...f357072) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.9.5 to 3.9.6. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rollup](https://github.com/rollup/rollup) from 2.18.1 to 2.18.2. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.18.1...v2.18.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Move `includeShebang` to `postprocess` * Style
* Add more tests for logical assignment operator * Make tests shorter
Co-authored-by: fisker Cheung <[email protected]> Co-authored-by: Boyen Vaesen <[email protected]>
Bumps [@glimmer/syntax](https://github.com/glimmerjs/glimmer-vm) from 0.54.0 to 0.54.1. - [Release notes](https://github.com/glimmerjs/glimmer-vm/releases) - [Changelog](https://github.com/glimmerjs/glimmer-vm/blob/master/CHANGELOG.md) - [Commits](glimmerjs/glimmer-vm@v0.54.0...v0.54.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix inconsistent formatting on Vue interpolation * Fix text * Update changelog * Fix snapshot * Add an explanation to the changelog Co-authored-by: Georgii Dolzhykov <[email protected]>
Bumps [eslint](https://github.com/eslint/eslint) from 7.3.1 to 7.4.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.3.1...v7.4.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rollup](https://github.com/rollup/rollup) from 2.18.2 to 2.19.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.18.2...v2.19.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [graphql](https://github.com/graphql/graphql-js) from 15.2.0 to 15.3.0. - [Release notes](https://github.com/graphql/graphql-js/releases) - [Commits](graphql/graphql-js@v15.2.0...v15.3.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@typescript-eslint/typescript-estree](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-estree) from 3.5.0 to 3.6.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/typescript-estree/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v3.6.0/packages/typescript-estree) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rollup](https://github.com/rollup/rollup) from 2.19.0 to 2.20.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.19.0...v2.20.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [execa](https://github.com/sindresorhus/execa) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/sindresorhus/execa/releases) - [Commits](sindresorhus/execa@v4.0.2...v4.0.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rollup](https://github.com/rollup/rollup) from 2.20.0 to 2.21.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.20.0...v2.21.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@angular/compiler](https://github.com/angular/angular/tree/HEAD/packages/compiler) from 10.0.2 to 10.0.3. - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/master/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/10.0.3/packages/compiler) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [angular-estree-parser](https://github.com/ikatyang/angular-estree-parser) from 2.0.3 to 2.1.0. - [Release notes](https://github.com/ikatyang/angular-estree-parser/releases) - [Changelog](https://github.com/ikatyang/angular-estree-parser/blob/master/CHANGELOG.md) - [Commits](prettier/angular-estree-parser@v2.0.3...v2.1.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [flow-parser](https://github.com/facebook/flow) from 0.128.0 to 0.129.0. - [Release notes](https://github.com/facebook/flow/releases) - [Changelog](https://github.com/facebook/flow/blob/master/Changelog.md) - [Commits](facebook/flow@v0.128.0...v0.129.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Unfortunately, the precise-commit repo does not seem to have been maintained for about two years: - [most recent commit](nrwl/precise-commits@8038712) to master was on Mar 27, 2018 - [most recent release](nrwl/precise-commits@v1.0.1...v1.0.2) was on Feb 16, 2018 - [most recently closed issue](nrwl/precise-commits#19) was closed on Jul 29, 2018 I have [requested](nrwl/precise-commits#58) archiving. This is sad. I could think of several use-cases where a tool like `precise-commits` could be very useful, especially for already matured projects that are trying to onboard linting and prettifying.
with separate snapshot for paren spacing
into: tests/ternary-object-expressions (not tested with paren-spacing as this would be meaningless)
check for consistent formatting on prettierx side as discussed in: - eslint/eslint#13971 - standard/standard#1624 - #41
to avoid conflicts with updates from Prettier 2.1.0 Note that all ES parsers are tested in the prettierx-specific test subdirectories whenever possible.
as needed to pass error tests from Prettier 2.1.0
as tslib is no longer needed with updates from Prettier 2.1.0 effectively reverts 36147fa
before merging updates from Prettier 2.1.0
before merging updates from Prettier 2.1.0
updates from Prettier 2.1.0
…into dev Release 2.1.0 (with some updates still needed to pass all tests)
after merge of updates from Prettier 2.1.0
src/language-js/embed.js after merging updates from Prettier 2.1.0
importFormatting originally from: cb693fd (prettierx PR number 265) Co-authored-by: Christopher J. Brody <[email protected]> Co-authored-by: Dmitry Koterov <[email protected]>
(use babel-flow / babel-ts in *some* cases)
…/ remove old ternary formatting functionality
…ll-arguments.js *mostly* working
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using quite a few hacky tricks to get it mostly working
Some TODO items:
src/language-js/printer-estree.js
to use some more functions fromsrc/language-js/print/*.js
flow
andtypescript
parsers, if possible2.1.1
and possibly2.2.0
or2.2.1