Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prettierx: fix balanced ternary formatting, with a simpler solultion #492

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

prettierx: fix balanced ternary formatting, with a simpler solultion #492

wants to merge 1 commit into from

Conversation

brody4hire
Copy link
Owner

@brody4hire brody4hire commented Mar 8, 2021 •
edited
Loading

resolves #468

(I think this would have been the right solution for #41)

BREAKING CHANGE

I think this would effectively undo some changes contributed by @aMarCruz in the past, which were needed to be consistent with older versions of "Standard JS". Newer versions of "Standard JS" are using indent rule with a new offsetTernaryExpressions option so there, as discussed in #41.

TODO:

  • update tests
  • double-check the effect on some other ternary formatting cases
  • possibly rename the ternary formatting option (again)
  • remove some more outdated code (??)

@brody4hire brody4hire added the bug Something isn't working label Mar 8, 2021
@brody4hire brody4hire self-assigned this Mar 8, 2021
This was referenced Mar 8, 2021
Open
Open
@brody4hire brody4hire mentioned this pull request May 25, 2021
Open
brody4hire pushed a commit that referenced this pull request Jun 23, 2021
Merge branch 'fix-balanced-ternary-formatting' of https://github.com/…
c81099e 
…brodybits/prettierx into update-balanced-ternary-formatting-support

include update from:

- #492

(brodybits/prettierx PR #492)
brody4hire pushed a commit that referenced this pull request Jun 23, 2021
update test snapshots in tests/ternaries/with-balanced-formatting (...)
021afa5 
add note:

The changes from these updates close #492 (brodybits/prettierx PR #492).
brody4hire pushed a commit that referenced this pull request Jun 23, 2021
update test snapshots in tests/ternaries/with-balanced-formatting (...)
8fef2ec 
add commit notes:

The changes from these updates close #492 (brodybits/prettierx PR #492).

add footer:

BREAKING CHANGE
@brody4hire brody4hire mentioned this pull request Jun 23, 2021
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brody4hire brody4hire

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

known --offset-ternary-expressions formatting issues
1 participant
@brody4hire